Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge develop to next/kelvin/410 #707

Merged
merged 16 commits into from
Aug 13, 2024
Merged

Merge develop to next/kelvin/410 #707

merged 16 commits into from
Aug 13, 2024

Conversation

pkova
Copy link
Collaborator

@pkova pkova commented Aug 13, 2024

No description provided.

Josh Lehman and others added 16 commits April 16, 2024 06:34
#622 helped with this, but it's still overly laconic about what's going
on. I think this is better.
Informal pinging has been broken since #623, luckily this was
unreleased, but existed edge.
The PR replaces vere's current (buggy, insufficient) lockfile mechanism
with an advisory `fcntl()` write lock (`F_SETLK`, `F_WRLCK`) on the
first byte of vere's PID file (`$pier/.vere.lock`). It does not (yet?)
include the functionality to kill the lock-holder and take over the
pier, as I'm not sure that's desirable.

There have been many problems with vere's current lockfile
implementation. The biggest advantage of this approach is that the lock
is automatically released if the process is killed or the host system
crashes. The biggest question is: does it work reliably across docker
shared volumes, virtual machines, &c.
@pkova pkova requested a review from a team as a code owner August 13, 2024 14:27
@pkova pkova merged commit 2c33ef6 into next/kelvin/410 Aug 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants